joshua/rclcpp
Public Access
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
1,976 Commits 155 Branches 195 Tags
native_buffer/8-rclcpp
Commit Graph

301 Commits

Author SHA1 Message Date
Janosch Machowinski
f145c9ee04 perf: Optimized out shared_ptr copies (#3079) 
* perf: Optimized out shared_ptr copies

Signed-off-by: Janosch Machowinski <J.Machowinski@cellumation.com>

* chore: indentation

Signed-off-by: Janosch Machowinski <J.Machowinski@cellumation.com>

---------

Signed-off-by: Janosch Machowinski <J.Machowinski@cellumation.com>
Co-authored-by: Janosch Machowinski <j.machowinski@cellumation.com>
 2026-03-03 13:43:55 +01:00
Alejandro Hernandez Cordero
866c56d153 30.1.5 2026-02-09 13:28:44 +01:00
Alejandro Hernandez Cordero
6a244e3305 Changelog 
Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
 2026-02-09 13:28:42 +01:00
Tomoya Fujita
b009212508 remove default: so that compiler can detect the missing case. (#3048) 
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
 2026-02-02 12:31:55 +01:00
Andrei Costinescu
6397047d47 Update exception documentation for goal cancellation in ServerGoalHandle (#3019) 
* Update exception documentation for goal cancellation

The documentation for the canceled function is misleading.
Previously, the description said: 
1. "Only call this if the goal is canceling." and 
2. "\throws rclcpp::exceptions::RCLError If the goal is in any state besides executing."
This is a contradiction.
Experimentally verified that if the goal is executing and this method is called, an error is thrown. This makes the second statement wrong => correct the statement in the documentation.

Signed-off-by: Andrei Costinescu <AndreiCostinescu@users.noreply.github.com>
 2026-01-20 09:57:19 +01:00
Alejandro Hernandez Cordero
a4a72ac544 30.1.4 2025-12-23 11:05:21 +01:00
Alejandro Hernandez Cordero
4e166cbed3 Changelog 
Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
 2025-12-23 11:05:17 +01:00
Alejandro Hernandez Cordero
f160024ba4 30.1.3 2025-11-18 11:09:53 +01:00
Alejandro Hernandez Cordero
e6ea37ed5a Changelog 
Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
 2025-11-18 11:09:49 +01:00
Tim Clephas
ad019b9827 Fix REP url locations (#2987) 
This popped up in my global replace

Signed-off-by: Tim Clephas <tim.clephas@nobleo.nl>
 2025-11-17 10:01:03 +01:00
Alejandro Hernandez Cordero
4d14414d91 30.1.2 2025-10-21 11:43:39 +02:00
Alejandro Hernandez Cordero
7fcc7e723c Changelog 
Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
 2025-10-21 11:43:35 +02:00
Tomoya Fujita
aa60fcf22a it misses the iterator second to lock the weakptr. (#2958) 
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
 2025-09-30 07:56:36 +09:00
Tomoya Fujita
b14af74a4c try aborting before canceling 1st on dtor of ServerGoalHandle. (#2953) 
* try aborting before canceling 1st on dtor of ServerGoalHandle.

Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>

* address review comments from Copilot AI.

Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>

* add missing header file and descriptions in docsection.

Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>

---------

Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
 2025-09-16 14:06:05 +09:00
Alejandro Hernandez Cordero
380866b338 30.1.1 2025-09-11 15:10:23 +02:00
Alejandro Hernandez Cordero
150a0e8ad9 Changelog 
Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
 2025-09-11 15:10:16 +02:00
Alberto Soragna
bdab46d64e deprecate rclcpp::spin_some and rclcpp::spin_all (#2848) 
* reorder events executor constructor arguments to have the first args match the other executors

Signed-off-by: Alberto Soragna <alberto.soragna@gmail.com>

* deprecate rclcpp::spin_some and rclcpp::spin_all

Signed-off-by: Alberto Soragna <alberto.soragna@gmail.com>

* use rcpputils to ignore deprecation and remove deprecated APIs from comments

Signed-off-by: Alberto Soragna <alberto.soragna@gmail.com>

* fix rclcpp_lifecycle build failures.

Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>

* make linters happy

Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>

* fix test_service_introspection

Signed-off-by: Alberto Soragna <alberto.soragna@gmail.com>

* fix lifecycle unit-test

Signed-off-by: Alberto Soragna <alberto.soragna@gmail.com>

---------

Signed-off-by: Alberto Soragna <alberto.soragna@gmail.com>
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
Co-authored-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
 2025-08-26 19:26:34 +09:00
Chris Lalancette
b7e4aad091 30.1.0 2025-07-29 21:03:19 +00:00
Chris Lalancette
fb6d43c5e0 Changelog. 
Signed-off-by: Chris Lalancette <clalancette@gmail.com>
 2025-07-29 21:03:12 +00:00
mosfet80
6392ee5187 fix cmake deprecation (#2914) 
cmake version < then 3.10 is deprecated

Signed-off-by: Mos <realeandrea@yahoo.it>
 2025-07-24 08:57:47 +02:00
Chris Lalancette
05eafed5b2 30.0.0 2025-07-01 15:46:34 +00:00
Chris Lalancette
eac7d1ad68 Changelog. 
Signed-off-by: Chris Lalancette <clalancette@gmail.com>
 2025-07-01 15:46:17 +00:00
Alejandro Hernandez Cordero
5beec9e32b 29.6.1 2025-06-23 16:00:13 +02:00
Alejandro Hernandez Cordero
6ee3a55fc3 Changelog 
Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
 2025-06-23 16:00:09 +02:00
keeponoiro
db8d917a12 Replace std::default_random_engine with std::mt19937 (rolling) (#2843) 
Signed-off-by: keeponoiro <keeeeeeep@gmail.com>
 2025-05-29 15:29:57 -07:00
Alejandro Hernández Cordero
373a63c5e6 Added missing chrono includes (#2854) 
Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
 2025-05-23 00:22:27 +02:00
Scott K Logan
1a282064a9 29.6.0 2025-04-25 15:04:18 -05:00
Scott K Logan
11afffad50 29.5.0 2025-04-18 16:01:12 -05:00
Tomoya Fujita
6ad551a5cc use std::recursive_mutex for action requests. (#2798) 
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
 2025-04-10 20:43:47 -07:00
Michael Carroll
892cae9915 29.4.0 2025-04-04 13:42:38 +00:00
Michael Carroll
14c8dd1072 Changelog. 
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
 2025-04-04 13:42:12 +00:00
Alejandro Hernández Cordero
fb8e1dda25 Remove warning (#2790) 
Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
 2025-03-31 15:22:47 +02:00
Tomoya Fujita
ce86ef7e62 Harden rclcpp_action::convert(). (#2786) 
* Harden rclcpp_action::convert().

Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>

* update docstring.

Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>

---------

Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
 2025-03-29 21:00:41 -07:00
Barry Xu
687057ffb6 Add new interfaces to enable introspection for action (#2743) 
* Add new interfaces to enable intropsection for action

Signed-off-by: Barry Xu <barry.xu@sony.com>

* Correct some comments

Signed-off-by: Barry Xu <barry.xu@sony.com>

---------

Signed-off-by: Barry Xu <barry.xu@sony.com>
 2025-03-12 08:27:06 -07:00
Barry Xu
9db7659dab Implement action generic client (#2759) 
Signed-off-by: Barry Xu <barry.xu@sony.com>
 2025-03-07 18:01:25 +01:00
Tomoya Fujita
6c10f941d3 use maybe_unused attribute for the portability. (#2758) 
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
 2025-02-27 10:44:29 +01:00
Janosch Machowinski
6069c3df10 fix: Expose timers used by rclcpp::Waitables (#2699) 
Signed-off-by: Janosch Machowinski <J.Machowinski@cellumation.com>
 2025-01-30 18:04:41 +01:00
Tomoya Fujita
9cabd69412 Collect log messages from rcl, and reset. (#2720) 
* Collect log messages from rcl, and reset.

Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>

* call rcl_reset_error once the error message is collected.

Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>

* address CI failure, error is already collected and reset.

Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>

---------

Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
 2025-01-07 19:28:02 -08:00
Chris Lalancette
a0a2a067d8 29.3.0 2024-12-20 16:16:13 +00:00
Chris Lalancette
094618a044 Changelog. 
Signed-off-by: Chris Lalancette <clalancette@gmail.com>
 2024-12-20 16:16:06 +00:00
Nathan Wiebe Neufeldt
785a70d604 Make ament_cmake a buildtool dependency (#2689) 
* Make ament_cmake a buildtool dependency

The `ament_cmake` package isn't needed at runtime and so should only be
listed as a `buildtool_dependency`, as is done in most other packages.

* Remove the ament_cmake dependency entirely

Since there's already a buildtool dependency on ament_cmake_ros, having
ament_cmake as well is redundant.

Signed-off-by: Nathan Wiebe Neufeldt <nwiebeneufeldt@clearpath.ai>
 2024-12-01 19:49:35 -05:00
Chris Lalancette
83c282a161 29.2.0 2024-11-25 14:38:16 +00:00
Chris Lalancette
226044022a Changelog. 
Signed-off-by: Chris Lalancette <clalancette@gmail.com>
 2024-11-25 14:38:05 +00:00
Chris Lalancette
64dd644469 29.1.0 2024-11-20 15:53:57 +00:00
Chris Lalancette
322b5f5d79 Changelog. 
Signed-off-by: Chris Lalancette <clalancette@gmail.com>
 2024-11-20 15:53:48 +00:00
YR
1e6767ac13 Fix documentation typo in server_goal_handle.hpp (#2669) 
Signed-off-by: Yurii Rovinskyi <yurii.rovinskyi.19@pnu.edu.ua>
 2024-11-10 07:54:41 -08:00
Chris Lalancette
16290fb352 29.0.0 2024-10-03 16:06:52 +00:00
Chris Lalancette
e133cc65f6 Changelog. 
Signed-off-by: Chris Lalancette <clalancette@gmail.com>
 2024-10-03 16:06:42 +00:00
Chris Lalancette
50a1e50133 Increase the timeout for the cppcheck on rclcpp_action. (#2640) 
The default is 300 seconds, but on Windows this is taking
between 250 and 300 seconds (I'm seeing it timeout sometimes).
Up the timeout to 600 seconds, which should be more than enough.

Signed-off-by: Chris Lalancette <clalancette@gmail.com>
 2024-10-03 10:33:15 -04:00
Alberto Soragna
a78d0cbd33 add smart pointer macros definitions to action server and client base classes (#2631) 
Signed-off-by: Alberto Soragna <alberto.soragna@gmail.com>
 2024-09-16 18:42:47 +02:00