Alejandro Hernández Cordero
1f408e3b19
Shutdown the context before context's destructor is invoked in tests ( #2633 )
...
* zenoh: Shutdown the node properly in component tests
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com >
* Call rclcpp::shutdown when tearing down tests in rclcpp
Signed-off-by: Yadunund <yadunund@intrinsic.ai >
* Call rclcpp::shutdown when tearing down tests in rclcpp_lifecycle
Signed-off-by: Yadunund <yadunund@intrinsic.ai >
* Ensure context is initialized for all tests in test_publisher
Signed-off-by: Yadunund <yadunund@intrinsic.ai >
* Added feedback
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com >
* make linters happy
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com >
---------
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com >
Signed-off-by: Yadunund <yadunund@intrinsic.ai >
Co-authored-by: Yadunund <yadunund@intrinsic.ai >
2024-09-24 09:36:54 -07:00
Alejandro Hernández Cordero
b1fdb18f1e
Updated rcpputils path API ( #2579 )
...
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com >
2024-07-24 10:14:45 +02:00
Josh Langsfeld
b9ef1fedfa
Use std compliant non-method std::filesystem::exists function ( #1502 )
...
Signed-off-by: Josh Langsfeld <josh.langsfeld@gmail.com >
2021-01-05 11:18:46 -05:00
Audrow Nash
febe86e6b5
Fix string literal warnings ( #1442 )
...
* Add warnings
Signed-off-by: Audrow Nash <audrow.nash@gmail.com >
* Fix nonliteral string warnings
Signed-off-by: Audrow Nash <audrow.nash@gmail.com >
* Fix compile error from new logging functions in rclcpp_components
Signed-off-by: Audrow Nash <audrow.nash@gmail.com >
* Use "%s" to make log string evaluation secure
Signed-off-by: Audrow Nash <audrow.nash@gmail.com >
* Fix logging warnings in rclcpp
Signed-off-by: Audrow Nash <audrow.nash@gmail.com >
* Fix coding style to pass linter
Signed-off-by: Audrow Nash <audrow.nash@gmail.com >
* Get the c_str of streams
Signed-off-by: Audrow Nash <audrow.nash@gmail.com >
* Remove test to check string logging
Signed-off-by: Audrow Nash <audrow.nash@gmail.com >
* Add in stream logging tests
Signed-off-by: Audrow Nash <audrow.nash@gmail.com >
2020-12-18 09:44:59 -08:00
brawner
cac761373f
Increasing test coverage of rclcpp_components ( #1044 )
...
* Increasing test coverage of rclcpp_components
Signed-off-by: Stephen Brawner <brawner@gmail.com >
* PR fixup
Signed-off-by: Stephen Brawner <brawner@gmail.com >
* Fixup
Signed-off-by: Stephen Brawner <brawner@gmail.com >
* Removing throws test for now
Signed-off-by: Stephen Brawner <brawner@gmail.com >
2020-05-12 10:26:49 -07:00
Karsten Knese
50d500e84e
Make Component Manager public ( #1065 )
...
* make functions public & virtual
Signed-off-by: Karsten Knese <karsten@openrobotics.org >
* flexible resource index for cmake macros
Signed-off-by: Karsten Knese <karsten@openrobotics.org >
* review comments
Signed-off-by: Karsten Knese <karsten@openrobotics.org >
* remove superfluous include
Signed-off-by: Karsten Knese <karsten@openrobotics.org >
* remove wrong dllexort
Signed-off-by: Karsten Knese <karsten@openrobotics.org >
* check for empty plugin & executable args
Signed-off-by: Karsten Knese <karsten@openrobotics.org >
* remove commented lines
Signed-off-by: Karsten Knese <karsten@openrobotics.org >
* fix typo
Signed-off-by: Karsten Knese <karsten@openrobotics.org >
* relax macro constraints
Signed-off-by: Karsten Knese <karsten@openrobotics.org >
2020-04-15 19:08:04 -07:00
Dan Rose
4a5eed968c
Add line break after first open paren in multiline function call ( #785 )
...
* Add line break after first open paren in multiline function call
as per developer guide:
https://index.ros.org/doc/ros2/Contributing/Developer-Guide/#open-versus-cuddled-braces
see https://github.com/ament/ament_lint/pull/148
Signed-off-by: Dan Rose <dan@digilabs.io >
Fix dedent when first function argument starts with a brace
Signed-off-by: Dan Rose <dan@digilabs.io >
Line break with multiline if condition
Remove line breaks where allowed.
Signed-off-by: Dan Rose <dan@digilabs.io >
Fixup after rebase
Signed-off-by: Dan Rose <dan@digilabs.io >
Fixup again after reverting indent_paren_open_brace
Signed-off-by: Dan Rose <dan@digilabs.io >
* Revert comment spacing change, condense some lines
Signed-off-by: Dan Rose <dan@digilabs.io >
2019-08-07 08:33:06 -07:00
Michael Carroll
0f25f714fe
Introduce rclcpp_components to implement composition ( #665 )
...
* Introduce rclcpp_components package
Signed-off-by: Michael Carroll <michael@openrobotics.org >
* Keep pointer to NodeWrapper vs NodeInterface.
Signed-off-by: Michael Carroll <michael@openrobotics.org >
* Remove component registration from rclcpp
Signed-off-by: Michael Carroll <michael@openrobotics.org >
* Make topics names private-prefix.
Signed-off-by: Michael Carroll <michael@openrobotics.org >
* Handle name and namespace with remap rules.
Signed-off-by: Michael Carroll <michael@openrobotics.org >
* Linting.
Signed-off-by: Michael Carroll <michael@openrobotics.org >
* Address reviewer feedback.
Signed-off-by: Michael Carroll <michael@openrobotics.org >
* Change to smart pointers for managing memory.
Signed-off-by: Michael Carroll <michael@openrobotics.org >
* Update to use rcpputils filesystem/split.
Signed-off-by: Michael Carroll <michael@openrobotics.org >
* Address reviewer feedback and add docs.
Signed-off-by: Michael Carroll <michael@openrobotics.org >
* Add tests around ComponentManager.
Signed-off-by: Michael Carroll <michael@openrobotics.org >
* Lint.
Signed-off-by: Michael Carroll <michael@openrobotics.org >
* Address reviewer feedback and add overflow check.
Signed-off-by: Michael Carroll <michael@openrobotics.org >
* Fix CI.
Signed-off-by: Michael Carroll <michael@openrobotics.org >
2019-04-04 11:16:32 -05:00