* Stop using constref signature of benchmark DoNotOptimize.
Newer versions of google benchmark (1.8.2 in my case) warn
that the compiler may optimize away the DoNotOptimize calls
when using the constref version. Get away from that here
by explicitly *not* calling the constref version, casting
where necessary.
Signed-off-by: Chris Lalancette <clalancette@gmail.com>
clang static analysis complains that there are dead stores in
most of the benchmark tests, which is technically correct.
We use an idiom like:
for (auto _ : state) {
}
And never access _. Silence clang here by doing (void)_;
all of the places this is seen.
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
