add noexcept to get_parameter methods.

https://github.com/ros2/rclcpp/issues/2047 Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
2022-11-28 11:06:17 -08:00
7 changed files with 7 additions and 7 deletions
--- a/rclcpp/include/rclcpp/node.hpp
+++ b/rclcpp/include/rclcpp/node.hpp
@@ -777,7 +777,7 @@ public:
   */
  RCLCPP_PUBLIC
  bool
-  get_parameter(const std::string & name, rclcpp::Parameter & parameter) const;
+  get_parameter(const std::string & name, rclcpp::Parameter & parameter) const noexcept;

  /// Get the value of a parameter by the given name, and return true if it was set.
  /**
--- a/rclcpp/include/rclcpp/node_interfaces/node_parameters.hpp
+++ b/rclcpp/include/rclcpp/node_interfaces/node_parameters.hpp
@@ -162,7 +162,7 @@ public:
  bool
  get_parameter(
    const std::string & name,
-    rclcpp::Parameter & parameter) const override;
+    rclcpp::Parameter & parameter) const noexcept override;

  RCLCPP_PUBLIC
  bool
--- a/rclcpp/include/rclcpp/node_interfaces/node_parameters_interface.hpp
+++ b/rclcpp/include/rclcpp/node_interfaces/node_parameters_interface.hpp
@@ -176,7 +176,7 @@ public:
  bool
  get_parameter(
    const std::string & name,
-    rclcpp::Parameter & parameter) const = 0;
+    rclcpp::Parameter & parameter) const noexcept = 0;

  /// Get all parameters that have the specified prefix into the parameters map.
  /*
--- a/rclcpp/src/rclcpp/node.cpp
+++ b/rclcpp/src/rclcpp/node.cpp
@@ -375,7 +375,7 @@ Node::get_parameter(const std::string & name) const
 }

 bool
-Node::get_parameter(const std::string & name, rclcpp::Parameter & parameter) const
+Node::get_parameter(const std::string & name, rclcpp::Parameter & parameter) const noexcept
 {
  return node_parameters_->get_parameter(name, parameter);
 }
--- a/rclcpp/src/rclcpp/node_interfaces/node_parameters.cpp
+++ b/rclcpp/src/rclcpp/node_interfaces/node_parameters.cpp
@@ -938,7 +938,7 @@ NodeParameters::get_parameter(const std::string & name) const
 bool
 NodeParameters::get_parameter(
  const std::string & name,
-  rclcpp::Parameter & parameter) const
+  rclcpp::Parameter & parameter) const noexcept
 {
  std::lock_guard<std::recursive_mutex> lock(mutex_);

--- a/rclcpp_lifecycle/include/rclcpp_lifecycle/lifecycle_node.hpp
+++ b/rclcpp_lifecycle/include/rclcpp_lifecycle/lifecycle_node.hpp
@@ -482,7 +482,7 @@ public:
  bool
  get_parameter(
    const std::string & name,
-    rclcpp::Parameter & parameter) const;
+    rclcpp::Parameter & parameter) const noexcept;

  /// Get the value of a parameter by the given name, and return true if it was set.
  /**
--- a/rclcpp_lifecycle/src/lifecycle_node.cpp
+++ b/rclcpp_lifecycle/src/lifecycle_node.cpp
@@ -251,7 +251,7 @@ LifecycleNode::get_parameter(const std::string & name) const
 bool
 LifecycleNode::get_parameter(
  const std::string & name,
-  rclcpp::Parameter & parameter) const
+  rclcpp::Parameter & parameter) const noexcept
 {
  return node_parameters_->get_parameter(name, parameter);
 }